Add user-defined types#177
Merged
Merged
Conversation
UDTs can be *any* fixed-length numpy type that doesn't have Python objects. Basically, UDFs that operate on the UDTs need to be able to be compiled with `@numba.njit`.
Some usage of `lookup_dtype` is not unnecessary now that ops use dtypes instead of dtype names. Also, using `get_typed_op` is preferred over `unify` where possible.
Member
Author
|
Whew! Okay, I think this is pretty much done. Tests and coverage are as solid as I can reasonably make them. Final thoughts and future possibilities:
This PR opens up a whole universe of possibilities. Record dtypes and array dtypes support different use cases, and both can be super-important. Anyway, I think this PR should be merged ASAP, but feedback is welcome for any who are courageous enough to review it (CC @jim22k). Although I think things are pretty good, we can always smooth any rough edges we find once we actually implement workloads that needs UDTs. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UDTs can be any fixed-length numpy type that doesn't have Python objects.
Basically, UDFs that operate on the UDTs need to be able to be compiled with
@numba.njit.Still lots to do, but many things are already working!