Skip any tests that required rust to be installed when it isn't available#3688
Closed
alsutton wants to merge 4 commits into
Closed
Skip any tests that required rust to be installed when it isn't available#3688alsutton wants to merge 4 commits into
alsutton wants to merge 4 commits into
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This marks as tests that rely on a local rust installation as "skipped" rather than "failed", which makes it easier to test the bootstrapping of a rust language install.
Trying to test the rust language bootstrapping meant either trying it on an environment with a local rust install, which would interfere with a test for the availability of rust, or manually working out which tests were failing and whether those failures were related to the lack of system rust installation or not.
Relates to: #3687 #3678