lib: fix typos in esm loader comments#63465
Open
RonGamzu wants to merge 1 commit into
Open
Conversation
Three typos in comments in the importSyncForRequire path: - "check the whether" -> "check whether" - "kEvaluaing" -> "kEvaluating" (matches the symbol used elsewhere in the file) - "the the problematic" -> "the problematic" No functional change. Signed-off-by: RonGamzu <37371774+RonGamzu@users.noreply.github.com>
Collaborator
|
Review requested:
|
Qard
approved these changes
May 21, 2026
aduh95
approved these changes
May 21, 2026
Contributor
|
Fast-track has been requested by @aduh95. Please π to approve. |
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63465 +/- ##
=======================================
Coverage 90.06% 90.06%
=======================================
Files 714 714
Lines 225918 225918
Branches 42729 42736 +7
=======================================
+ Hits 203466 203468 +2
+ Misses 14231 14224 -7
- Partials 8221 8226 +5
π New features to boost your workflow:
|
lpinca
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three typos in comments in the
importSyncForRequirepath oflib/internal/modules/esm/loader.js:the file, e.g. the import on line 53 and the comparisons on lines
340 and 382)
Comment-only change; no functional impact.