Skip to content

add logging of exceptions during runtime environment create#20

Merged
dominikschubert merged 2 commits into
localstackfrom
avoid-duplicate-error-reporting-on-init-error
Jun 5, 2023
Merged

add logging of exceptions during runtime environment create#20
dominikschubert merged 2 commits into
localstackfrom
avoid-duplicate-error-reporting-on-init-error

Conversation

@dominikschubert
Copy link
Copy Markdown
Member

Avoids the Runtime Handler can only error while starting error logs in localstack when the invocation fails due to an error.

Previously it caused two "error reports", one via /invocations/<invokeid>/error and one via /status/<runtimeid>/<status>.

@dominikschubert dominikschubert requested review from dfangl and joe4dev May 31, 2023 14:55
@dominikschubert dominikschubert self-assigned this May 31, 2023
@joe4dev
Copy link
Copy Markdown
Member

joe4dev commented May 31, 2023

Copy link
Copy Markdown
Member

@joe4dev joe4dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Fixed in joint session with @dominikschubert and @dfangl

@dominikschubert dominikschubert merged commit d69fb6a into localstack Jun 5, 2023
@dominikschubert dominikschubert deleted the avoid-duplicate-error-reporting-on-init-error branch June 5, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants