Improve logging output#19
Merged
Merged
Conversation
* Support levels from Logrus * Adjust xray logging accordingly
dominikschubert
approved these changes
Apr 17, 2023
Member
dominikschubert
left a comment
There was a problem hiding this comment.
LGTM, the new default level seems to be a sensible balance between clarity and verbosity 👍
As discussed, in the future we should look into introducing more control over stdout/stderr and also printing the platform messages (START/END/REPORT, ..)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make init log levels configurable
Lambda container logs are very verbose such that it is hard for customers to identify what’s wrong with their Lambda implementation because the logs are mainly about RIE internals.
We already support log levels through the environment variable
LOCALSTACK_INIT_LOG_LEVELbut only debug and trace is insufficient.Go log levels: https://github.com/sirupsen/logrus#level-logging
What should be the default level? "warn + invocation result logging"
Follow Up
PrintEndReports(currently only sent to CloudWatch)