Add more FAIL codes for client-initiated batches#573
Merged
Conversation
While building out my implementation of this, I noticed that many instances of clients sending garbage to the server did not have a defined error code. My implementation provides a baseline support for the BATCH command while allowing other modules to define recognized batch types. As such, the handler for the BATCH command itself is generic and agnostic to the actual type being used. It still needs to do some basic tracking on the supplied reference tag and type before handing it off to the handler module, so cases where the reference tag and/or type are not valid need error messages. Rather than making something implementation-defined, it'd probably be best to specify some messages that can be used in this case. An implementation that doesn't split things up like mine does isn't required to use these additional messages, but having them specified lets clients know to expect them.
progval
approved these changes
Oct 26, 2025
Contributor
Author
|
As an implementation note, solanum now makes use of these additional codes for client-initiated batches as of solanum-ircd/solanum@4cc9be1 (plus a couple more related to nesting which aren't part of this PR as the current draft spec forbids nesting but the solanum implementation conditionally allows it for potential future specs which add nested client-initiated batches) |
Member
|
I'm fine with this. |
Member
|
Will aim to merge this at the end of the week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While building out my implementation of this, I noticed that many instances of clients sending garbage to the server did not have a defined error code. My implementation provides a baseline support for the BATCH command while allowing other modules to define recognized batch types. As such, the handler for the BATCH command itself is generic and agnostic to the actual type being used. It still needs to do some basic tracking on the supplied reference tag and type before handing it off to the handler module, so cases where the reference tag and/or type are not valid need error messages.
Rather than making something implementation-defined, it'd probably be best to specify some messages that can be used in this case. An implementation that doesn't split things up like mine does isn't required to use these additional messages, but having them specified lets clients know to expect them.