pipeline-manager: require program_info_url and schema unit test#6294
Merged
Conversation
The `program_info_url` is now a mandatory parameter for a pipeline to be able to be started, as its absence has been long enough deprecated. An error is added in case it is missing. This makes it consistent how program info is handled across runners. Add a unit test for the schema with only properties. Signed-off-by: Simon Kassing <simon.kassing@feldera.com>
mythical-fred
approved these changes
May 21, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
LGTM. Clean follow-up to #6288.
The new ProgramSchemaPropertiesOnly unit test directly answers the schema subset-parsing concern I raised on #6288 — good. The Option<&str> -> &str plumbing in PipelineExecutor::provision plus the hard AutomatonCannotConstructProgramInfoUrl transition is the right cleanup; there is only one real implementor (LocalRunner) plus the mock and both are updated.
One soft note (non-blocking):
- The new hard-error transit path in
pipeline_automata.rs— whenprogram_info_integrity_checksumisNone— has no test inrunner::pipeline_automata::test. Themissing_artifacts_sets_pendingscaffolding is already there; a tiny test that drives a pipeline whoseprogram_info_integrity_checksumwas never recorded intoTransitionToStopping{ AutomatonCannotConstructProgramInfoUrl }would lock the new contract in place. Worth a tracking issue at minimum, since this is the exact "long-enough-deprecated path now hard-errors" behavior change called out in the PR description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
program_info_urlis now a mandatory parameter for a pipeline to be able to be started, as its absence has been long enough deprecated. An error is added in case it is missing. This makes it consistent how program info is handled across runners.Add a unit test for the schema with only properties.