I also suggest adding a comment to specify that the colors must be in linear RGB mode, NOT sRGB which is what we get from popular colormap sources such as the ones in matplotlib. I was pulling my hairs today trying to figure out why the same thing on matplotlib and fastplotlib was different.

@kushalkolar Could we take a look into this? I've been using it for a few months without issue.

I also suggest adding a comment to specify that the colors must be in linear RGB mode, NOT sRGB which is what we get from popular colormap sources such as the ones in matplotlib. I was pulling my hairs today trying to figure out why the same thing on matplotlib and fastplotlib was different.

pygfx uses sRGB by default, can you play with pygfx.Color("name").to_physical() and pygfx.Color.from_physical() to see what's happening?

I also suggest adding a comment to specify that the colors must be in linear RGB mode, NOT sRGB which is what we get from popular colormap sources such as the ones in matplotlib. I was pulling my hairs today trying to figure out why the same thing on matplotlib and fastplotlib was different.

pygfx uses sRGB by default, can you play with pygfx.Color("name").to_physical() and pygfx.Color.from_physical() to see what's happening?

this is what i do. I set

self._mesh = self._figure[0, 0].add_mesh(
          self._mesh_vertices,
          self._mesh_indices,
          colors=self._random_colors,
          mode="basic"
      )

once. Then change that colors attribute with self._mesh.colors = any color array. It could be that i'm unknowingly bypassing the "to_physical" method, which explains why i have to convert to linear space myself

With pygfx.Color("teal").to_physical():

Without to_physical():

Are you expecting the former?

Sorry busy week. I'm not sure which one to be honest but yes it's the same conflict i have as it looks on pygfx docs:

Let me put it this way, add_mesh and add_image have different behaviors with respect to coloring. When im passing colors to the mesh, if I do not convert my own colors from sRGB to linear, it gets washed down. This does not happen with UI elements, or with the image plot. In fact I built the same thing for a mesh and an image plot, and noticed instantly that the fix I used for the mesh was making the image colors look bad, it eats sRGB colors. I'm having the exact same result on image vs mesh with this correction.

I suggest for now, as I wrote in the PR, that we just warn people that it needs colors in linear colorspace. Otherwise change the pygfx color transform that it's applying.