pr for extmap handling in bundle#32
Merged
Merged
Conversation
taylor-b
approved these changes
Mar 30, 2017
|
|
||
| <section title="RTP Header Extensions Consideration" anchor="sec-extmap" toc="default"> | ||
| <t>When <xref target="RFC5285"/> RTP header extensions are used in the context of this | ||
| specification, the identifier used for a given extension MUST identify the the same |
| <section title="RTP Header Extensions Consideration" anchor="sec-extmap" toc="default"> | ||
| <t>When <xref target="RFC5285"/> RTP header extensions are used in the context of this | ||
| specification, the identifier used for a given extension MUST identify the the same | ||
| extension across all the bundled media descriptions. </t> |
There was a problem hiding this comment.
I'd say "all media descriptions in the same BUNDLE group", since technically there may be multiple BUNDLE groups, and they could use different identifier spaces.
|
|
||
| <section title="RTP Header Extensions Consideration" anchor="sec-extmap" toc="default"> | ||
| <t>When <xref target="RFC5285"/> RTP header extensions are used in the context of this | ||
| specification, the identifier used for a given extension MUST identify the the same |
There was a problem hiding this comment.
It may be useful to mention "extmap" by name, to make it easy to find if someone searches for it. Could say "the identifier used for a given extension in an 'a=extmap' attribute MUST..."
|
LGTM. In practice existing implementations already do that, but it's better having it as a requirement in the spec. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.