feat(session): expose disableSpill and maxTempDirectorySize on SessionContextBuilder#84
Open
LantaoJin wants to merge 1 commit into
Open
feat(session): expose disableSpill and maxTempDirectorySize on SessionContextBuilder#84LantaoJin wants to merge 1 commit into
LantaoJin wants to merge 1 commit into
Conversation
Contributor
Author
|
Follow-up (no action needed before merging this PR): the new Javadoc on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
PR #28 added
tempDirectory(String)as the only Java surface for DataFusion'sRuntimeEnvBuilderdisk-manager knobs. Two real gaps remain — both reachable on the Rust side, neither reachable from Java today, and neither reachable viasetOption(...)because they live onRuntimeEnvconstruction rather than thedatafusion.*config namespace (the native side already explicitly rejectsdatafusion.runtime.*keys, for the same reason that motivated the existing typedmemoryLimit(...)/tempDirectory(...)setters):--disk-limitflag thatdatafusion-cliships.Issue #83 originally included a third setter,
tempDirectories(List<String>), but a follow-up survey of the upstream code, CLI, docs, examples, and Python binding showed multi-directory mode is a programmatic-only escape hatch onDiskManagerBuilder: not exposed byRuntimeEnvBuilderitself, not used bydatafusion-cli, not inconfigs.md, not in any example. It can ship later if a real user files an issue with a use case; punting it keeps this PR focused on the two setters with concrete motivation.What changes are included in this PR?
SessionContextBuilder:disableSpill().maxTempDirectorySize(long)DiskManagerOptionsmessage (optionaldisabled, optionalmax_temp_directory_size) added tosession_options.proto.createSessionContextWithOptionsthat decodesDiskManagerOptionsand routes throughwith_disk_manager_builder(Disabled)/with_max_temp_directory_size.Are these changes tested?
Yes. 9 new tests in
SessionContextBuilderTestAre there any user-facing changes?
Yes, additive only — no breaking changes.
SessionContextBuilder. Existing callers using onlytempDirectory(String)see no behaviour change and produce identical wire bytes.IllegalStateExceptionatbuild()time (not at the setter call), matching thesetOptionruntime-key pattern.cacheManager,registerObjectStore) shipped.